lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V6 1/6] regmap: irq: dispose all virtual irq before removing domain

On Tuesday 09 February 2016 06:57 PM, Javier Martinez Canillas wrote:
> Hello Laxman,
>
> On 02/09/2016 09:28 AM, Laxman Dewangan wrote:
>> It is require to dispose all virtual irq of hwirq on chip
>> created on given irq domain before removing this irq domain.
>> Hence dispose all mapped irqs before deleting the irq domains
>> in regmap_del_irq_chip();
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>>
>
> I believe this patch could be picked separately and not made part of
> this series since is fixing a bug that happens on most drivers using
> the regmap-irq API. This will avoid cross-subsystem churn for people.
>
> Your patch 6/6 does not introduce a regression since the bug already
> exists in the MFD driver, it just makes it more noticeable since it
> is easier to unbind the max77686 RTC driver than the MFD one.


If we dont have fix then rtc unbind/bind creates issue on S2R. Although
it was issue on tot but the issue visible with my patch only.

So if you test my 2 to 6 without 1, you will see issue.

So to avoid bisect issue in functionality wise, this should go on
sequence. This is my view.


\
 
 \ /
  Last update: 2016-02-09 15:21    [W:0.053 / U:33.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site