lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 20/22] media: au0828 add enable, disable source handlers
Em Mon, 08 Feb 2016 16:00:26 -0700
Shuah Khan <shuahkh@osg.samsung.com> escreveu:

> >>> + ret = __media_entity_pipeline_start(entity, pipe);
> >>> + if (ret) {
> >>> + pr_err("Start Pipeline: %s->%s Error %d\n",
> >>> + source->name, entity->name, ret);
> >>> + ret = __media_entity_setup_link(found_link, 0);
> >>> + pr_err("Deactive link Error %d\n", ret);
> >>> + goto end;
> >>> + }
> >>
> >> Hmm... isn't it to early to activate the pipeline here? My original
> >> guess is that, on the analog side, this should happen only at the stream
> >> on code. Wouldn't this break apps like mythTV?
>
> On analog side, there are a few ioctls that
> change the configuration on the tuner way
> before stream on step. Is there a reason to
> separate the setup_link() and pipeline_start()
> steps? I can separate these two steps, but I
> am not really seeing the reason for that.

I'm actually ok with that, provided that it won't break existing
apps. Did you test it with MythTV?

Regards,
Mauro

\
 
 \ /
  Last update: 2016-02-09 15:21    [W:0.079 / U:25.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site