lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header
On Tue, 9 Feb 2016, Daniel Wagner wrote:

> > All error/warnings (new ones prefixed by >>):
> >
> > arch/mips/kernel/../../../fs/binfmt_elf.c: In function 'load_elf_interp':
> >>> arch/mips/kernel/binfmt_elfn32.c:38:7: error: implicit declaration of function 'mips_elf_check_machine' [-Werror=implicit-function-declaration]
> > if (!mips_elf_check_machine(__h)) \
> > ^
> >>> arch/mips/kernel/../../../fs/binfmt_elf.c:536:7: note: in expansion of macro 'elf_check_arch'
> > if (!elf_check_arch(interp_elf_ex))
> > ^
> > cc1: some warnings being treated as errors
> > --
> > arch/mips/kernel/../../../fs/binfmt_elf.c: In function 'load_elf_interp':
>
> Hmm how I was able to build binfmt_elfo32.o because it should suffer
> from the same problem.
>
> I think reusing mips_elf_check_machine() in binfmt_elf?32.c is only
> going to work if we include arch/mips/include/asm/elf.h. Though this
> looks kind of wrong.

But neither binfmt_elf?32.c actually expands `elf_check_arch' and both
include fs/binfmt_elf.c at the end, which in turn includes <linux/elf.h>,
which in turn does include <asm/elf.h> before expanding `elf_check_arch',
and consequently at that point `mips_elf_check_machine' will have been
already defined. So things are all right, except you need to define the
macro outside `#ifndef ELF_ARCH'.

I suggest moving it down, right below the conditional, rather than up as
the top of the file contains generic MIPS ELF stuff. I think all the
three macros can go together, it doesn't appear to me they need to depend
on `ELF_ARCH', and we can fix it up if ever in the future they have to.

FWIW I think all the MIPS ABI flags stuff also needs to go outside the
conditional, because it's ABI agnostic. I'll make the right change myself
on top of your fixes. It'll remove a little bit of code duplication,
which is always welcome.

Maciej

\
 
 \ /
  Last update: 2016-02-09 14:01    [W:0.070 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site