lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/14] x86/efi: Print size in binary units in efi_print_memmap

* Elliott, Robert (Persistent Memory) <elliott@hpe.com> wrote:

>
> > -----Original Message-----
> > From: Matt Fleming [mailto:matt@codeblueprint.co.uk]
> > Sent: Wednesday, February 3, 2016 5:28 AM
> > To: Ingo Molnar <mingo@kernel.org>
> > Cc: Laszlo Ersek <lersek@redhat.com>; H . Peter Anvin <hpa@zytor.com>;
> > Thomas Gleixner <tglx@linutronix.de>; linux-efi@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Elliott, Robert (Persistent Memory)
> > <elliott@hpe.com>; Andy Shevchenko <andriy.shevchenko@linux.intel.com>;
> > Ard Biesheuvel <ard.biesheuvel@linaro.org>; Taku Izumi
> > <izumi.taku@jp.fujitsu.com>; Linus Torvalds <torvalds@linux-
> > foundation.org>; Andrew Morton <akpm@linux-foundation.org>
> > Subject: Re: [PATCH 14/14] x86/efi: Print size in binary units in
> > efi_print_memmap
> ...
> > OK, this patch has caused enough headaches. Let's drop it from this
> > series.
> >
> > Robert, Andy, feel free to resubmit it after you've addressed
> > everyone's concerns and we can discuss it in isolation.
>
> We could just delete the size print altogether - better to print
> nothing than a silently rounded number. The end address already
> communicates the size - it's just not as readable.
>
> The e820 table prints don't bother with a size print.
>
> That would also shorten these extremely wide prints to 116
> characters (131 if printk time is enabled).
>
> [ 0.000000] BIOS-e820: [mem 0x0000001880000000-0x000000207fffffff] reserved
> vs.
> [ 0.000000] efi: mem62: [Reserved | | |NV| | | | | |WB|WT|WC|UC] range=[0x0000001880000000-0x000000207fffffff] (32 GiB)

So I find the latter a lot more readable - my terminals are wide enough ;-)

Humans are also rather bad at parsing 64-bit hexa address ranges at a glance, so
the size display is very useful.

But the flags portion should be shortened via appropriately chosen
single-character abbreviations for the flags. Anyone deeply intimate with the code
will recognize the flags - others won't care one way or another.

plus there's no need to write out 'range='.

... and please keep the size and just use GB/TB for chrissake.

I.e. something like this would work for me:

> [ 0.000000] efi: mem62: 0x0000001880000000-0x000000207fffffff ( 32 GB) .N....BTCU "Reserved"

Thanks,

Ingo

\
 
 \ /
  Last update: 2016-02-09 13:41    [W:0.122 / U:3.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site