lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86/lib/copy_user_64.S: Handle 4-byte nocache copy

* Borislav Petkov <bp@suse.de> wrote:

> On Tue, Feb 09, 2016 at 11:27:41AM +0100, Ingo Molnar wrote:
> > So another pet peeve of mine is to not use numeric labels, please use
> > descriptively named labels instead.
>
> ... and prepend them with ".L" so that they become local labels.

Yes. A good example to follow would be arch/x86/entry/entry_64.S.

Btw., IIRC GAS is being silly about .L, i.e. there's a difference between these
two variants:

.Lerror_entry_from_usermode_swapgs:
.L_error_entry_from_usermode_swapgs:

the latter would be easier to read, but does not result in a local label last I
checked.

Right?

Thanks,

Ingo

\
 
 \ /
  Last update: 2016-02-09 13:01    [W:0.056 / U:34.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site