Messages in this thread | | | Date | Tue, 9 Feb 2016 11:52:56 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] x86/kernel: use pr_<level>() and dev_<level> |
| |
On Tue, 9 Feb 2016, Ingo Molnar wrote: > > * Chen Yucong <slaoub@gmail.com> wrote: > > > arch/x86/kernel/* use a mixture of printk(KERN_<level> ) and pr_<level>(). > > This patch converts the bulk of printk(KERN_<level> ) to pr_<level>() and > > uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning() > > calls have been replaced with pr_warn(). > > > > Not sure what to do about the printk(KERN_DEFAULT) and printk() without a > > log level. > > > > Signed-off-by: Chen Yucong <slaoub@gmail.com> > > When converting please also join broken up format strings, such as: > > - printk(KERN_WARNING PREFIX > - "HPET id: %#x base: 0xfed0000000000000 fixed up " > - "to 0xfed00000.\n", hpet_tbl->id); > + pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up " > + "to 0xfed00000.\n", hpet_tbl->id); > > ignore checkpatch: we don't line-break user visible strings.
And please get rid of PREFIX. define pr_fmt instead.
Thanks,
tglx
| |