Messages in this thread | | | Date | Tue, 9 Feb 2016 11:09:36 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH RESEND] kprobe: Use percpu counter to collect nhit statistics |
| |
* Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 4 Feb 2016 10:24:12 +0000 > 平松雅巳 / HIRAMATU,MASAMI <masami.hiramatsu.pt@hitachi.com> wrote: > > > From: Martin KaFai Lau [mailto:kafai@fb.com] > > > > > >When doing ebpf+kprobe on some hot TCP functions (e.g. > > >tcp_rcv_established), the kprobe_dispatcher shows up in 'perf report'. > > > > > >In kprobe_dispatcher(), there is a lot of cache bouncing > > >in 'tk->nhit++'. 'tk->nhit' and 'tk->tp.flags' also share > > >the same cacheline. > > > > > > > Ingo, could you consider to merge this? > > > > Ingo, you can also add my > > Acked-by: Steven Rostedt <rostedt@goodmis.org>
Yeah, nice optimization, picked it up - thanks guys!
Ingo
| |