lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] hv_netvsc: Increase delay for RNDIS_STATUS_NETWORK_CHANGE
From
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Tue, 2 Feb 2016 16:15:56 -0800

> We simulates a link down period for RNDIS_STATUS_NETWORK_CHANGE message to
> trigger DHCP renew. User daemons may need multiple seconds to trigger the
> link down event. (e.g. ifplugd: 5sec, network-manager: 4sec.) So update
> this link down period to 10 sec to properly trigger DHCP renew.
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>

Two things look really bad about this to me:

1) Any value you choose is arbitrary. If some new network configuration daemon
is slower, you will have to change this value again.

This is _NOT_ sustainable in the long term.

2) It is completely unclear to me why this driver needs to delay at all or
wait for anything. I see no other driver having to deal with this issue.

Until you address both of these points I am not going to apply this patch.

Thanks.

\
 
 \ /
  Last update: 2016-02-09 11:21    [W:0.108 / U:7.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site