lkml.org 
[lkml]   [2016]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 00/16] Common Dell SMBIOS API
On Mon, Feb 08, 2016 at 10:04:32PM +0100, Pali Rohár wrote:
> On Monday 08 February 2016 21:46:46 Darren Hart wrote:
> > Pali, are you happy enough with this to add your reviewed-by?
>
> There was dicussion about dell-smbios API which you probably missed in
> tons of other emails. It has subject:
>
> "[PATCH 01/14] dell-laptop: extract SMBIOS-related code to a separate module"
>
> And you can find it in archive at:
> http://www.spinics.net/lists/linux-leds/msg05379.html
>
> I wanted to hear your opinion about this API and I'm not 100% fine with
> it but on other side it is not easy to design better... Maybe you could
> have better idea.

I will review the above. However, a new API can be treated as separate from
the refactoring which is all this series really does. It doesn't do anything
that I saw beyond moving existing code into a separate module and wrapping the
use of the buffer and tokens. In that sense, it seems to me that this can be
considered a first step toward a redesigned API by first removing duplicate code
and reusing some of the existing code.

--
Darren Hart
Intel Open Source Technology Center

\
 
 \ /
  Last update: 2016-02-08 22:41    [W:1.016 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site