Messages in this thread | | | Date | Mon, 8 Feb 2016 09:31:21 +0100 | Subject | Re: [PATCH 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs | From | Geert Uytterhoeven <> |
| |
On Sun, Feb 7, 2016 at 6:38 PM, Luis Henriques <luis.henriques@canonical.com> wrote: > Several network-related data structures are defined in gelic_udbg. > These could be easily dropped and the standard ones defined in network > headers could be used instead. > > The 4 patches that follow replace ethernet, vlan, ip and udp > structures in gelic_udbg. Note that this has been compile-tested > only.
A few of these were declared __packed in the gelic driver, while that attribute isn't used for the standard definitions.
It probably doesn't make a difference, as there are no gaps in the structures when unpacked, unless pointers to the structures themselves are unaligned.
> Luis Henriques (4): > powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h> > powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h> > powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h> > powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h> > > arch/powerpc/platforms/ps3/gelic_udbg.c | 71 +++++++++++---------------------- > 1 file changed, 23 insertions(+), 48 deletions(-)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |