lkml.org 
[lkml]   [2016]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 47/87] ALSA: timer: Fix double unlink of active_list
    3.2.77-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit ee8413b01045c74340aa13ad5bdf905de32be736 upstream.

    ALSA timer instance object has a couple of linked lists and they are
    unlinked unconditionally at snd_timer_stop(). Meanwhile
    snd_timer_interrupt() unlinks it, but it calls list_del() which leaves
    the element list itself unchanged. This ends up with unlinking twice,
    and it was caught by syzkaller fuzzer.

    The fix is to use list_del_init() variant properly there, too.

    Reported-by: Dmitry Vyukov <dvyukov@google.com>
    Tested-by: Dmitry Vyukov <dvyukov@google.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    sound/core/timer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/core/timer.c
    +++ b/sound/core/timer.c
    @@ -692,7 +692,7 @@ void snd_timer_interrupt(struct snd_time
    } else {
    ti->flags &= ~SNDRV_TIMER_IFLG_RUNNING;
    if (--timer->running)
    - list_del(&ti->active_list);
    + list_del_init(&ti->active_list);
    }
    if ((timer->hw.flags & SNDRV_TIMER_HW_TASKLET) ||
    (ti->flags & SNDRV_TIMER_IFLG_FAST))
    \
     
     \ /
      Last update: 2016-02-09 01:41    [W:4.206 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site