lkml.org 
[lkml]   [2016]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak
On Fri, Jan 29, 2016 at 10:07:32PM -0800, John Stultz wrote:
> From: San Mehat <san@google.com>
>
> As it turns out, the CONFIG_PROFILING interfaces leak a
> task struct if the notifier chain returns NOTIFY_OK.. doh.
>
> This patch reworks lowmemkiller to use the new generic task
> free notifier chain.
>
> Cc: Android Kernel Team <kernel-team@android.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Signed-off-by: San Mehat <san@google.com>
> [jstultz: Commit subject tweak]
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> drivers/staging/android/lowmemorykiller.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
> index 8b5a4a8..806643d 100644
> --- a/drivers/staging/android/lowmemorykiller.c
> +++ b/drivers/staging/android/lowmemorykiller.c
> @@ -40,7 +40,6 @@
> #include <linux/sched.h>
> #include <linux/swap.h>
> #include <linux/rcupdate.h>
> -#include <linux/profile.h>
> #include <linux/notifier.h>
>
> static u32 lowmem_debug_level = 1;
> --
> 1.9.1

The changelog comment seems a bit "odd" when looking at the patch here.
Is the patch really correct? The changelog?

totally confused,

greg k-h

\
 
 \ /
  Last update: 2016-02-08 00:21    [W:0.286 / U:0.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site