Messages in this thread | | | Date | Thu, 4 Feb 2016 06:40:00 -0200 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH v2 02/22] media: Add ALSA Media Controller function entities |
| |
Em Wed, 03 Feb 2016 21:03:34 -0700 Shuah Khan <shuahkh@osg.samsung.com> escreveu:
> Add ALSA Media Controller capture, playback, and mixer > function entity defines. > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > include/uapi/linux/media.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index ee020e8..7d50480 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -98,6 +98,17 @@ struct media_device_info { > #define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 42) > > /* > + * DOC: Media Controller Next Generation ALSA Function Entities > + * > + * MEDIA_ENT_F_AUDIO_CAPTURE - Audio Capture Function > + * MEDIA_ENT_F_AUDIO_PLAYBACK - Audio Play Back Function > + * MEDIA_ENT_F_AUDIO_MIXER - Audio Mixer Function > +*/
Wrong way to document it. Please see my comments to patch 01/22.
> +#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 200) > +#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 201) > +#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 202) > + > +/* > * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and > * MEDIA_ENT_F_OLD_SUBDEV_BASE are kept to keep backward compatibility > * with the legacy v1 API.The number range is out of range by purpose:
| |