lkml.org 
[lkml]   [2016]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ext4: add a line break for proc mb_groups display
From
Date
On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote:
> On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote:
> > This patch adds a line break for proc mb_groups display.

Using 2 lines for output might break any existing users.

Are there any?

> >
> > Signed-off-by: Huaitong Han <huaitong.han@intel.com>
> > ---
> >  fs/ext4/mballoc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> > index 61eaf74..4424b7b 100644
> > --- a/fs/ext4/mballoc.c
> > +++ b/fs/ext4/mballoc.c
> > @@ -2285,7 +2285,7 @@ static int ext4_mb_seq_groups_show(struct seq_file *seq, void *v)
> >   if (group == 0)
> >   seq_puts(seq, "#group: free  frags first ["
> >         " 2^0   2^1   2^2   2^3   2^4   2^5   2^6  "
> > -       " 2^7   2^8   2^9   2^10  2^11  2^12  2^13  ]");
> > +       " 2^7   2^8   2^9   2^10  2^11  2^12  2^13  ]\n");
>
> Oh, heh.
>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> --D
>
> >  
> >   i = (sb->s_blocksize_bits + 2) * sizeof(sg.info.bb_counters[0]) +
> >   sizeof(struct ext4_group_info);

\
 
 \ /
  Last update: 2016-02-03 20:21    [W:0.547 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site