lkml.org 
[lkml]   [2016]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] net/smscx5xx: use the device tree for mac address
    Date
    On Wednesday 03 February 2016 16:02:38 Lubomir Rintel wrote:
    > From: Arnd Bergmann <arnd@arndb.de>
    >
    > This takes the MAC address for smsc75xx/smsc95xx USB network devices
    > from a the device tree. This is required to get a usable persistent
    > address on the popular beagleboard, whose hardware designers
    > accidentally forgot that an ethernet device really requires an a
    > MAC address to be functional.
    >
    > The smsc75xx and smsc95xx drivers are just two copies of the
    > same code, so better fix both.
    >
    > Tested-by: Lubomir Rintel <lkundrak@v3.sk>
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    >

    I have no memory of writing this patch, where did you find it?

    The changelog sounds like I wrote it, so I assume it was me after all.

    > + address = of_get_property(dev->udev->dev.of_node,
    > + "local-mac-address", NULL);
    > + if (address) {
    > + memcpy(dev->net->dev_addr, address, ETH_ALEN);
    > + return;
    > + }

    This should use of_get_mac_address(), not an open-coded property
    lookup. The function was probably added after I wrote the
    the original patch.

    Arnd

    \
     
     \ /
      Last update: 2016-02-03 16:41    [W:2.417 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site