lkml.org 
[lkml]   [2016]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6] SATA: OCTEON: support SATA on OCTEON platform
Date
On Wednesday 03 February 2016 13:24:10 Zubair Lutfullah Kakakhel wrote:
> > Typically we treat those special registers as part of the device itself
> > and have a single device node for the AHCI controller and that one.
> >
> > What is your reason for doing it differently here?
>
> Two reasons
>
> 1- The hardware is like a proper split rather than additional hidden registers in
> the same memory space.
>
> 2- Tons of devices in the field have the following DT node built in the bootloader.
>
> uctl@118006c000000 {
> compatible = "cavium,octeon-7130-sata-uctl";
> reg = <0x11800 0x6c000000 0x0 0x100>;
> ...
> sata: sata@16c0000000000 {
> compatible = "cavium,octeon-7130-ahci";
> reg = <0x16c00 0x00000000 0x0 0x200>;
> ...
> };
> };
>
> The patch suggests a way to handle this.
>

Ok, fair enough. Also, you write in the binding that this is a bus
bridge, so this indeed matches what the hardware does, and that's ok.

Does the bus bridge actually translate the entire 64-bit CPU MMIO space,
or is it possible that it only handles one device (or a couple of
them) with a fairly limited space?

Maybe it's better to represent it as a #address-cells=<1> in the
example, and have the child device appear at address 0 in there.

For the machines that already ship a DT, that would not matter though,
it works either way.

Arnd

\
 
 \ /
  Last update: 2016-02-03 15:21    [W:0.075 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site