lkml.org 
[lkml]   [2016]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/5] dts: sun8i-h3: Add APB0 related clocks and resets
    Hi,

    On Tue, Feb 02, 2016 at 10:21:50PM +0100, Krzysztof Adamski wrote:
    > APB0 is bearly mentioned in H3 User Manual and it is only setup in the
    > Allwinners kernel dump for CIR. I have verified experimentally that the
    > gate for R_PIO exists and works, though. There are probably other gates
    > there but I don't know their order right now and I don't have access to
    > their peripherals on my board to test them.
    >
    > Signed-off-by: Krzysztof Adamski <k@japko.eu>
    > ---
    > arch/arm/boot/dts/sun8i-h3.dtsi | 32 ++++++++++++++++++++++++++++++++
    > 1 file changed, 32 insertions(+)
    >
    > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
    > index 1524130e..ce35e93 100644
    > --- a/arch/arm/boot/dts/sun8i-h3.dtsi
    > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
    > @@ -276,6 +276,32 @@
    > clocks = <&osc24M>, <&pll6 1>, <&pll5>;
    > clock-output-names = "mbus";
    > };
    > +
    > + ahb0: ahb0_clk {
    > + compatible = "fixed-factor-clock";
    > + #clock-cells = <0>;
    > + clock-div = <1>;
    > + clock-mult = <1>;
    > + clocks = <&osc24M>, <&osc32k>;
    > + clock-output-names = "ahb0";
    > + };

    I'm not sure what you mean there. The fixed factor clocks only take a
    single parent, and you provided two.

    Maxime

    --
    Maxime Ripard, Free Electrons
    Embedded Linux, Kernel and Android engineering
    http://free-electrons.com
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2016-02-03 13:41    [W:6.731 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site