Messages in this thread | | | Date | Tue, 1 Mar 2016 09:54:32 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field |
| |
Hi Ingo,
On Mon, 29 Feb 2016 09:01:43 +0100 Ingo Molnar <mingo@kernel.org> wrote: > > * Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > u32? > > > > It would have to be __u32, but we already use int and unsigned int > > extensively in the siginfo structure (which are both always assumed to > > be 32 bits). So "unsigned int" probably makes most sense. > > No. This whole mishap is an object lesson in why it's a bad idea to ever use ABI > types outside of the __[us][8|16|32|64] space: some of them are 'fine', some of > them (like longs) are not.
Absolutely. I was just trying to be consistent with the rest of the structure.
Dave has submitted a follow up version which I have Acked.
-- Cheers, Stephen Rothwell
| |