lkml.org 
[lkml]   [2016]   [Feb]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field
Hi Ingo,

On Mon, 29 Feb 2016 09:01:43 +0100 Ingo Molnar <mingo@kernel.org> wrote:
>
> * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > > u32?
> >
> > It would have to be __u32, but we already use int and unsigned int
> > extensively in the siginfo structure (which are both always assumed to
> > be 32 bits). So "unsigned int" probably makes most sense.
>
> No. This whole mishap is an object lesson in why it's a bad idea to ever use ABI
> types outside of the __[us][8|16|32|64] space: some of them are 'fine', some of
> them (like longs) are not.

Absolutely. I was just trying to be consistent with the rest of the structure.

Dave has submitted a follow up version which I have Acked.

--
Cheers,
Stephen Rothwell

\
 
 \ /
  Last update: 2016-03-01 00:41    [W:1.571 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site