lkml.org 
[lkml]   [2016]   [Feb]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: fs: NULL deref in atime_needs_update
    On Mon, Feb 29, 2016 at 08:45:37AM -0800, Linus Torvalds wrote:

    > > David, Linus, do you see any problems with that? To me it looks saner
    > > that way and as cheap as the current code, but I might be missing something
    > > here...
    >
    > I'd absolutely love to see this. The memory ordering for the flags
    > updates and reading was always really confusing, and I hated how it
    > was hidden inside the random access functions. And apparently it
    > wasn't just confusing, it was buggy too.
    >
    > But I'd love it _more_ if this also means that we can get rid of the
    > rmb's, which your patch didn't. Can we? Or does the ordering still
    > remain for some other issue?

    In __d_entry_type(), you mean? Should be, along with READ_ONCE() there.
    AFAICS, ordering shouldn't be an issue anymore...

    \
     
     \ /
      Last update: 2016-02-29 18:41    [W:2.364 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site