lkml.org 
[lkml]   [2016]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 1/5] getcpu_cache system call: cache CPU number of running thread
From
On Sat, Feb 27, 2016 at 6:58 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> Paul's patches have the following structure:
>
> struct thread_local_abi {
> union {
> struct {
> u32 cpu_id;
> u32 seq;
> };
> u64 cpu_seq;
> };
> unsigned long post_commit_ip;
> };

Please don't do "unsigned long" in ABI structures any more.

Make it u64, and make sure it is 64-bit aligned (which it would be in
this case). Make it so that we don't have to have separate compat
paths.

Linus

\
 
 \ /
  Last update: 2016-02-27 20:21    [W:0.116 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site