lkml.org 
[lkml]   [2016]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] spi: lp-8841: return correct error code from probe
    From
    Date
    On Thu, 2016-02-25 at 12:37 +0100, Arnd Bergmann wrote:
    > The spi_lp8841_rtc_probe() function misses an initialization of the
    > return code when it fails to get its memory resource, as gcc notices:
    >
    > drivers/spi/spi-lp8841-rtc.c: In function 'spi_lp8841_rtc_probe':
    > drivers/spi/spi-lp8841-rtc.c:239:9: error: 'ret' may be used
    > uninitialized in this function [-Werror=maybe-uninitialized]
    >
    > This changes the code to propagate the error from
    > devm_ioremap_resource().
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > Fixes: 7ecbfff6711f ("spi: master driver to enable RTC on ICPDAS LP-
    > 8841")

    Tested-by: Sergei Ianovich <ynvich@gmail.com>

    \
     
     \ /
      Last update: 2016-02-25 18:41    [W:4.349 / U:0.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site