Messages in this thread | | | Subject | Re: [PATCH V2] phy: ralink-usb: add driver for Mediatek/Ralink | From | John Crispin <> | Date | Thu, 25 Feb 2016 12:03:27 +0100 |
| |
On 22/02/2016 11:48, Kishon Vijay Abraham I wrote: > Hi Rob, > > On Tuesday 05 January 2016 01:03 AM, John Crispin wrote: >> Add a driver to setup the USB phy on Mediatek/Ralink SoCs. >> The driver is trivial and only sets up power and host mode. >> >> Signed-off-by: John Crispin <blogic@openwrt.org> >> --- >> Changes in V2 >> * remove refcounting >> * drop empty functions >> * dont use static globals >> * use explicit compatible strings >> >> .../devicetree/bindings/phy/ralink-usb-phy.txt | 17 ++ >> drivers/phy/Kconfig | 8 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-ralink-usb.c | 175 ++++++++++++++++++++ >> 4 files changed, 201 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/ralink-usb-phy.txt >> create mode 100644 drivers/phy/phy-ralink-usb.c >> >> diff --git a/Documentation/devicetree/bindings/phy/ralink-usb-phy.txt b/Documentation/devicetree/bindings/phy/ralink-usb-phy.txt >> new file mode 100644 >> index 0000000..5b27cad >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/ralink-usb-phy.txt >> @@ -0,0 +1,17 @@ >> +Mediatek/Ralink USB PHY >> + >> +Required properties: >> + - compatible: ralink,rt3352-usbphy or mediatek,mt7620-usbphy >> + - #phy-cells: should be 0 >> + - resets: the two reset controllers for host and device >> + - reset-names: the names of the 2 reset controllers >> + > > Does this binding documentation look okay to you? Should the documentation come > in a separate file? > > Thanks > Kishon >
let me resend the whole thing as a V3 split into 2 patches
John
| |