Messages in this thread | | | Date | Wed, 24 Feb 2016 11:06:04 -0500 | Subject | Re: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y | From | Alex Deucher <> |
| |
On Wed, Feb 24, 2016 at 9:58 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Alex, > > On Wed, Feb 24, 2016 at 3:48 PM, Deucher, Alexander > <Alexander.Deucher@amd.com> wrote: >>> -----Original Message----- >>> From: Geert Uytterhoeven [mailto:geert+renesas@glider.be] >>> Sent: Wednesday, February 24, 2016 3:14 AM >>> To: David Airlie; Deucher, Alexander; Bayyavarapu, Maruthi >>> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Geert >>> Uytterhoeven >>> Subject: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y >>> >>> By default, not only this driver is enabled on all platforms, but also >>> generic PM Domains and Multi-Function Devices. >>> >>> Drop the "default y" to fix this. >> >> I guess I don't really care per se, but why is this an issue? > > Because it causes kernel bloat on all platforms that are not AMD SoCs. > I noticed the option and the selected options were suddenly enabled when > running "make ARCH=sh se7724_defconfig". > > As a general use, never use "default y", unless the system fails completely > in the absence of the module. Even then, there should be some dependencies > listed.
Got it. Applied, thanks,
Alex
> > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
| |