lkml.org 
[lkml]   [2016]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 120/142] ARM: 8519/1: ICST: try other dividends than 1
    Date
    From: Linus Walleij <linus.walleij@linaro.org>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit e972c37459c813190461dabfeaac228e00aae259 upstream.

    Since the dawn of time the ICST code has only supported divide
    by one or hang in an eternal loop. Luckily we were always dividing
    by one because the reference frequency for the systems using
    the ICSTs is 24MHz and the [min,max] values for the PLL input
    if [10,320] MHz for ICST307 and [6,200] for ICST525, so the loop
    will always terminate immediately without assigning any divisor
    for the reference frequency.

    But for the code to make sense, let's insert the missing i++

    Reported-by: David Binderman <dcb314@hotmail.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    arch/arm/common/icst.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/arm/common/icst.c b/arch/arm/common/icst.c
    index 2dc6da70ae59..3b3e58b7ba74 100644
    --- a/arch/arm/common/icst.c
    +++ b/arch/arm/common/icst.c
    @@ -58,6 +58,7 @@ icst_hz_to_vco(const struct icst_params *p, unsigned long freq)

    if (f > p->vco_min && f <= p->vco_max)
    break;
    + i++;
    } while (i < 8);

    if (i >= 8)
    --
    2.7.1
    \
     
     \ /
      Last update: 2016-02-24 12:01    [W:4.085 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site