lkml.org 
[lkml]   [2016]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ubifs: Implement O_TMPFILE
From
Date
Am 23.02.2016 um 21:45 schrieb Pavel Machek:
> Hi!
>
>> + ui = ubifs_inode(inode);
>> +
>> + err = ubifs_init_security(dir, inode, &dentry->d_name);
>> + if (err)
>> + goto out_inode;
>> +
>> + mutex_lock(&ui->ui_mutex);
>> + insert_inode_hash(inode);
>> + d_tmpfile(dentry, inode);
>> + ubifs_assert(ui->dirty);
>> + instantiated = 1;
>> + mutex_unlock(&ui->ui_mutex);
>> +
>> + mutex_lock(&dir_ui->ui_mutex);
>> + err = ubifs_jnl_update(c, dir, &dentry->d_name, inode, 1, 0);
>> + if (err)
>> + goto out_cancel;
>> + mutex_unlock(&dir_ui->ui_mutex);
>
> Move the if () below unlock, and make it goto out_inode?

Yes. That's better. :)

Thanks,
//richard

\
 
 \ /
  Last update: 2016-02-23 22:41    [W:0.038 / U:1.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site