Messages in this thread Patch in this message | | | From | Andrzej Hajda <> | Subject | [PATCH 1/2] gpio: xgene: fix type of variable containing error codes | Date | Tue, 23 Feb 2016 07:45:34 +0100 |
| |
ret variable can contain error values and is compared with zero. Its type must be signed.
The problem has been detected using coccinelle script scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- drivers/gpio/gpio-xgene-sb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c index b993b86..fd81ebc 100644 --- a/drivers/gpio/gpio-xgene-sb.c +++ b/drivers/gpio/gpio-xgene-sb.c @@ -240,7 +240,7 @@ static const struct irq_domain_ops xgene_gpio_sb_domain_ops = { static int xgene_gpio_sb_probe(struct platform_device *pdev) { struct xgene_gpio_sb *priv; - u32 ret; + int ret; struct resource *res; void __iomem *regs; struct irq_domain *parent_domain = NULL; -- 1.9.1
| |