Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer | Date | Mon, 22 Feb 2016 22:28:10 +0000 |
| |
Tadeusz Struk <tadeusz.struk@intel.com> wrote:
> I wonder if this should be merged with the crypto/rsa-pkcs1pad.c template > that we already have. Looks like the two do the same padding now. > Should we merge then and pass the hash param as a separate template param, > e.g the public_key would allocate "pkcs1pad(rsa, sha1)"?
Ummm... Possibly. Is that how it's used?
warthog>git grep pkcs1pad -- Documentation warthog1>
Anyway, the problem I have with this is that I want to get that knowledge out of the asymmetric key in-software public key subtype. It knows "rsa", "dsa", "ecdsa", ... because that's all the OIDs tell it.
I guess if I have to, I can stoop to converting "rsa" to "pkcs1pad(rsa, sha1)".
Can you do me a really quick merge? -rc5 is already out, and I want to get it to James pronto - plus I have things that are pending on this change being made.
Oh - and how does the padding template find the algorithm DER encoding string to use? I have wondered whether it should be stored in with the hash algorithm, but it probably makes more sense to keep it with the rsa module.
David
| |