lkml.org 
[lkml]   [2016]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ARM: OMAP2+: Fix onenand initialization to avoid filesystem corruption
From
Date
Hi,

On 11.02.2016 02:12, Tony Lindgren wrote:
>
> Also.. There's a chance somebody has created a onenand file system
> with recent mainline kernels that did the reset and disabled ECC.
> So with Ivaylo's patch fixing that, those may not mount properly
> any longer. Most likely people just keep their maemo rootfs there
> though with the MMC being available.

I guess this is possible, but what worries me more is that the longer
the patch is not pushed, the higher the chance somebody to end-up with
broken rootfs. Wouldn't it be better to push it, thus preventing that
happening?

BTW the differences for N9/50 come from ONENAND_SYS_CFG1_HF bit and
ONENAND_SYS_CFG1_BRL_6 vs ONENAND_SYS_CFG1_BRL_4. Both are changed
(later in the code) anyway, so I guess it is safe to reset them to
default values.

Or, maybe the correct fix is to issue RESET command to onenand
controller after GPMC reset? RESET command is supposed to put all the
bits to their default values.

Ivo.

\
 
 \ /
  Last update: 2016-02-21 19:41    [W:0.057 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site