lkml.org 
[lkml]   [2016]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters
From
Date
On Sat, 2016-02-20 at 12:17 -0600, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
[]
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
[]
> @@ -1830,7 +1830,11 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
>   unsigned long ptr;
>  
>   while (1) {
> - ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> + ret = btrfs_find_one_extref(fs_root,
> + inum,
> + offset,
> + path,
> + &extref,
>       &offset);

I think this is poor because all the arguments aren't aligned.

It'd be nicer like:

ret = btrfs_find_one_extref(fs_root, inum, offset, path,
&extref, &offset);

\
 
 \ /
  Last update: 2016-02-21 01:41    [W:0.082 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site