Messages in this thread | | | Date | Fri, 19 Feb 2016 23:51:07 -0500 (EST) | Subject | Re: [PATCH net] af_unix: Don't use continue to re-execute unix_stream_read_generic loop | From | David Miller <> |
| |
From: Rainer Weikusat <rweikusat@mobileactivedefense.com> Date: Thu, 18 Feb 2016 12:39:46 +0000
> The unix_stream_read_generic function tries to use a continue statement > to restart the receive loop after waiting for a message. This may not > work as intended as the caller might use a recvmsg call to peek at > control messages without specifying a message buffer. If this was the > case, the continue will cause the function to return without an error > and without the credential information if the function had to wait for a > message while it had returned with the credentials otherwise. Change to > using goto to restart the loop without checking the condition first in > this case so that credentials are returned either way. > > Signed-off-by: Rainer Weikusat <rweikusat@mobileactivedefense.com> > Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied, thanks.
| |