Messages in this thread | | | Subject | Re: [PATCH v4 1/2] usb: musb: Fix DMA for host mode | From | Sergei Shtylyov <> | Date | Fri, 19 Feb 2016 20:54:07 +0300 |
| |
Hello.
On 02/19/2016 07:41 PM, Joshua Henderson wrote:
> From: Cristian Birsan <cristian.birsan@microchip.com> > > Commit ac33cdb16681 ("usb: musb: Remove ifdefs for musb_host_rx in > musb_host.c part5") introduces a problem setting DMA host mode. > > This commit fixes the done condition that advances the musb schedule. > Without this patch the the msub_advance_schedule() is called immediately > after receiving an endpoint RX interrupt without waiting for the DMA > transfer to complete. As a consequence when the dma complete interrupt > arrives the in_qh member of hw_ep is already null an the musb_host_rx() > exits on !urb error case. > > Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com> > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com> > Tested-by: Ladislav Michl <ladis@linux-mips.org>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Although you didn't describe your changes to the original patch in the change log...
MBR, Sergei
| |