Messages in this thread | | | Date | Fri, 19 Feb 2016 13:20:14 +0900 | From | Andi Shyti <> | Subject | Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered |
| |
Hi Javier,
Just a question...
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index f4f36bba7be9..f3ce94ec73b5 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -1318,6 +1318,8 @@ static int exynos_tmu_probe(struct platform_device *pdev) > return ret; > } > } else { > + if (PTR_ERR(data->regulator) == -EPROBE_DEFER) > + return -EPROBE_DEFER;
shouldn't we return also in case of -ENOMEM? -ENOMEM is a Kernel failure, not depending on the regulator itself.
Andi
> dev_info(&pdev->dev, "Regulator node (vtmu) not found\n"); > }
| |