Messages in this thread | | | Subject | Re: [PATCH 7/9] rfkill: Create "rfkill-airplane_mode" LED trigger | From | Johannes Berg <> | Date | Thu, 18 Feb 2016 21:08:41 +0100 |
| |
On Mon, 2016-02-08 at 10:41 -0500, João Paulo Rechi Vita wrote: > This creates a new LED trigger to be used by platform drivers as a > default trigger for airplane-mode indicator LEDs. > > By default this trigger will fire when RFKILL_OP_CHANGE_ALL is called > for all types (RFKILL_TYPE_ALL), setting the LED brightness to > LED_FULL > when the changing the state to blocked, and to LED_OFF when the > changing > the state to unblocked. In the future there will be a mechanism for > userspace to override the default policy, so it can implement its > own. > > This trigger will be used by the asus-wireless x86 platform driver.
Just one comment - I think you should be consistent with the _ vs - and just use "rfkill-airplane-mode" as the name.
johannes
| |