lkml.org 
[lkml]   [2016]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] IB/core: Replace memset with eth_zero_addr
From
Date
On 2/12/2016 2:46 AM, Amitoj Kaur Chawla wrote:
> Use eth_zero_addr to assign the zero address to the given address
> array instead of memset when second argument is address of zero.
>
> The Coccinelle semantic patch used to make this change is as follows:
>
> // <smpl>
> @eth_zero_addr@
> expression e;
> @@
>
> -memset(e,0x00,ETH_ALEN);
> +eth_zero_addr(e);
> // </smpl>
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

Thanks, applied.

> ---
> drivers/infiniband/core/sa_query.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/sa_query.c b/drivers/infiniband/core/sa_query.c
> index f334090..4b3ac76 100644
> --- a/drivers/infiniband/core/sa_query.c
> +++ b/drivers/infiniband/core/sa_query.c
> @@ -1221,7 +1221,7 @@ static void ib_sa_path_rec_callback(struct ib_sa_query *sa_query,
> rec.net = NULL;
> rec.ifindex = 0;
> rec.gid_type = IB_GID_TYPE_IB;
> - memset(rec.dmac, 0, ETH_ALEN);
> + eth_zero_addr(rec.dmac);
> query->callback(status, &rec, query->context);
> } else
> query->callback(status, NULL, query->context);
>


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-02-18 19:21    [W:0.071 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site