lkml.org 
[lkml]   [2016]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] thermal: use %d to print S32 parameters
On Wed, Jan 13, 2016 at 09:22:16AM +0000, Javi Merino wrote:
> On Wed, Jan 13, 2016 at 04:33:56PM +0800, Leo Yan wrote:
> > Power allocator's parameters are S32 type, so use %d to print them.
>
> Indeed. The name of the macro is create_s32_tzp_attr(), it's
> explicitly saying that the parameter is signed!
>
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
>
> Acked-by: Javi Merino <javi.merino@arm.com>

Rui, Eduardo,

Could you help merge this patch as well?

Thanks,
Leo Yan

>
> Cheers,
> Javi
>
> > ---
> > drivers/thermal/thermal_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> > index d9e525c..1335df2 100644
> > --- a/drivers/thermal/thermal_core.c
> > +++ b/drivers/thermal/thermal_core.c
> > @@ -931,7 +931,7 @@ static DEVICE_ATTR(sustainable_power, S_IWUSR | S_IRUGO, sustainable_power_show,
> > struct thermal_zone_device *tz = to_thermal_zone(dev); \
> > \
> > if (tz->tzp) \
> > - return sprintf(buf, "%u\n", tz->tzp->name); \
> > + return sprintf(buf, "%d\n", tz->tzp->name); \
> > else \
> > return -EIO; \
> > } \
> > --
> > 1.9.1
> >

\
 
 \ /
  Last update: 2016-02-18 11:01    [W:0.031 / U:47.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site