Messages in this thread | | | Subject | Re: [PATCH] kbuild: disable Android-specific compiler features | From | Michal Marek <> | Date | Thu, 18 Feb 2016 10:36:03 +0100 |
| |
Dne 18.2.2016 v 00:03 Kees Cook napsal(a): > On Fri, Feb 5, 2016 at 4:44 PM, Kees Cook <keescook@chromium.org> wrote: >> The Android compilers enable some non-standard features by default. While >> most Android build systems inject the needed "-mno-android" option via >> KCFLAGS, it happens too late (at least on x86_64), since KBUILD_CFLAGS >> gains KCFLAGS after running (and failing) many cc-option tests. (For >> example, the stack-protector tests happen after arch-specific >> KBUILD_CFLAGS are added but before the external KCFLAGS are added.) As >> such, we should notice this option and immediately turn it on as the >> first cc-option test we run. >> >> Signed-off-by: Kees Cook <keescook@chromium.org> > > Michal, is this okay? I'd like to get it into -next soon if possible.
Is there a way to detect these compilers and are there some canonical versions of these? I do not think it's a good idea to add workaround for each random gcc fork.
Michal
| |