Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] lkdtm: add test for executing .rodata | Date | Wed, 17 Feb 2016 22:45:49 +0100 |
| |
On Wednesday 17 February 2016 22:44:12 Arnd Bergmann wrote: > On Tuesday 16 February 2016 13:49:04 Kees Cook wrote: > > } > > > > +static void __attribute__((__section__(".rodata,\"a\",@progbits#"))) > > +do_nothing_rodata(void) > > +{ > > + return; > > +} > > + > > static void do_nothing(void) > > { > > > > I think this also needs to be marked "noinline" to ensure that the > function does not get eliminated. I've seen clang do that on > execute_location() recently and submitted a patch for that.
Nevermind, this gets passed by reference into execute_location(), so it's enough if that is marked noinline, but do_nothing_rodata needs no such annotation.
Arnd
| |