lkml.org 
[lkml]   [2016]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] goldfish: Return proper error code
This change has been made with the goal that kernel functions should
return something more descriptive than -1 on failure.

Change the return value on valid_batchbuffer_addr() failure from -1
to -EINVAL.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/platform/goldfish/goldfish_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index 9f6734c..6de6fd2 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -233,7 +233,7 @@ static int setup_access_params_addr(struct platform_device *pdev,
dev->aps = aps;
return 0;
} else
- return -1;
+ return -EINVAL;
}

/* A value that will not be set by qemu emulator */
--
1.9.1
\
 
 \ /
  Last update: 2016-02-17 18:41    [W:0.036 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site