Messages in this thread | | | Subject | Re: [PATCH] lance: Return correct error code | From | Sergei Shtylyov <> | Date | Wed, 17 Feb 2016 17:16:21 +0300 |
| |
Hello.
On 2/17/2016 4:35 PM, Amitoj Kaur Chawla wrote:
> The return value of kzalloc on failure should be -ENOMEM and
kzalloc() returns NULL on failure! You need to clarify your patch description, so that it makes some sense.
> not -ENODEV. > > Additionally, removed the following checkpatch warnings: > ERROR: spaces required around that '==' (ctx:VxV) > ERROR: space required before the open parenthesis '(' > CHECK: Comparison to NULL could be written "!lp" > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> [...]
MBR, Sergei
| |