Messages in this thread | | | Subject | Re: [char-misc-next] mei: fix format string in debug prints | From | Joe Perches <> | Date | Wed, 17 Feb 2016 02:45:06 -0800 |
| |
On Wed, 2016-02-17 at 12:27 +0200, Tomas Winkler wrote: [] > buf_idx type was changed to size_t, and few places > missed out to change the print format from %ld to %zd.
trivia:
> diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c [] > @@ -128,7 +128,7 @@ int mei_cl_irq_read_msg(struct mei_cl *cl, > buf_sz = mei_hdr->length + cb->buf_idx; > /* catch for integer overflow */ > if (buf_sz < cb->buf_idx) { > - cl_err(dev, cl, "message is too big len %d idx %ld\n", > + cl_err(dev, cl, "message is too big len %d idx %zd\n", > mei_hdr->length, cb->buf_idx);
[etc...]
buf_idx is size_t and it should probably use %zu
ssize_t -> %zd size_t -> %zu
| |