Messages in this thread | | | Date | Tue, 16 Feb 2016 23:36:48 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH] perf/jvmti: add check for java alternatives cmd in Makefile |
| |
Hi Arnaldo and Stephane,
On Tue, Feb 16, 2016 at 12:31:26PM -0200, Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 16, 2016 at 07:37:41AM +0100, Stephane Eranian escreveu: > > This patch modifies the jvmti makefile to check > > if /usr/sbin/java-update-alternatives is present. > > If so, then use it, if not then use the altenatives > > command. This helps handle the difference between > > Ubuntu and Fedora Linux distributions. > > Thanks, tested and applied. > > We need tho to better integrate it with the 'make install' target, so > that it gets built and installed, this way it will end up packaged by > distros. > > That, together with documentation should be enough as a first step to > ease usage in a more widespread way.
It'd be better providing a reasonable default (if possible) or guide to how to setup the JDIR for other distro as well.
Thanks, Namhyung
| |