lkml.org 
[lkml]   [2016]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/6] clk: rockchip: check grf when waiting pll lock
Date
Am Montag, 15. Februar 2016, 11:33:25 schrieb Shawn Lin:
> rockchip_clk_get_grf pass on return value from
> syscon_regmap_lookup_by_phandle, so we check grf to
> make sure whether to do the following things or not.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

applied to my clk-branch for 4.6 with one change below

> ---
>
> drivers/clk/rockchip/clk-pll.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/rockchip/clk-pll.c
> b/drivers/clk/rockchip/clk-pll.c index b7e66c9..dddbc29 100644
> --- a/drivers/clk/rockchip/clk-pll.c
> +++ b/drivers/clk/rockchip/clk-pll.c
> @@ -90,10 +90,16 @@ static long rockchip_pll_round_rate(struct clk_hw *hw,
> */
> static int rockchip_pll_wait_lock(struct rockchip_clk_pll *pll)
> {
> - struct regmap *grf = rockchip_clk_get_grf();
> + struct regmap *grf;
> unsigned int val;
> int delay = 24000000, ret;
>
> + grf = rockchip_clk_get_grf();
> + if (IS_ERR(grf)) {
> + pr_err("%s: grf regmap not available\n", __func__);
> + return -ENODEV;

I've changed that to PTR_ERR(grf), similar to the preexisting checks


Heiko

\
 
 \ /
  Last update: 2016-02-15 23:01    [W:1.621 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site