Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/4] gpio: remove broken irq_to_gpio() interface | Date | Mon, 15 Feb 2016 21:16:30 +0100 |
| |
On Monday 15 February 2016 17:01:09 Lars-Peter Clausen wrote: > On 02/15/2016 04:46 PM, Arnd Bergmann wrote: > > +static inline __deprecated int irq_to_gpio(unsigned int irq) > > +{ > > + /* this has clearly not worked for a long time */ > > + return -EINVAL; > > +} > > + > > #define IRQ_TO_BIT(irq) BIT(irq_to_gpio(irq) & 0x1f) > > The issue seems to be a fallout from commit 832f5dacfa0b ("MIPS: Remove all > the uses of custom gpio.h"). > > The irq_to_gpio() should be replaced with "(irq - JZ4740_IRQ_GPIO(0))". > >
Ah, that explain it, so it has not been broken for that long.
Arnd
| |