lkml.org 
[lkml]   [2016]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH 0/7] fix IS_ERR_VALUE usage
    Date
    Hi,

    This small set of independent patches tries to fix incorrect
    IS_ERR_VALUE macro usage. It fixes most usages leading to errors
    as described in [1]. It also follows conclusion from the discussion
    [1][2] - IS_ERR_VALUE should be used only with unsigned long type,
    signed types should use comparison 'ret < 0'.

    The patchset does not fix errors present in net/ethernet/freescale
    and soc/fsq/qe drivers - these drivers mixes different types:
    dma_addr_t, u32, unsigned long, fixing it properly seems to me more
    challenging, maybe maintainers or brave volunteers can look it.

    The list of missing fixes:
    drivers/net/ethernet/freescale/fs_enet/mac-scc.c:149:36-37: WARNING: incorrect argument type in IS_ERR_VALUE(fep -> ring_mem_addr)
    drivers/net/ethernet/freescale/ucc_geth.c:2237:48-49: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> tx_bd_ring_offset [ j ])
    drivers/net/ethernet/freescale/ucc_geth.c:2314:48-49: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> rx_bd_ring_offset [ j ])
    drivers/net/ethernet/freescale/ucc_geth.c:2524:44-45: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> tx_glbl_pram_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:2544:45-46: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> thread_dat_tx_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:2571:46-47: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> send_q_mem_reg_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:2612:42-43: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> scheduler_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:2659:54-55: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> tx_fw_statistics_pram_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:2696:44-45: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> rx_glbl_pram_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:2715:45-46: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> thread_dat_rx_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:2736:54-55: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> rx_fw_statistics_pram_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:2756:53-54: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> rx_irq_coalescing_tbl_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:2822:44-45: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> rx_bd_qs_tbl_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:2908:47-48: WARNING: incorrect argument type in IS_ERR_VALUE(ugeth -> exf_glbl_param_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:292:36-37: WARNING: incorrect argument type in IS_ERR_VALUE(init_enet_offset)
    drivers/net/ethernet/freescale/ucc_geth.c:3042:39-40: WARNING: incorrect argument type in IS_ERR_VALUE(init_enet_pram_offset)
    drivers/soc/fsl/qe/ucc_fast.c:271:60-61: WARNING: incorrect argument type in IS_ERR_VALUE(uccf -> ucc_fast_tx_virtual_fifo_base_offset)
    drivers/soc/fsl/qe/ucc_fast.c:284:60-61: WARNING: incorrect argument type in IS_ERR_VALUE(uccf -> ucc_fast_rx_virtual_fifo_base_offset)
    drivers/soc/fsl/qe/ucc_slow.c:186:38-39: WARNING: incorrect argument type in IS_ERR_VALUE(uccs -> us_pram_offset)
    drivers/soc/fsl/qe/ucc_slow.c:213:38-39: WARNING: incorrect argument type in IS_ERR_VALUE(uccs -> rx_base_offset)
    drivers/soc/fsl/qe/ucc_slow.c:224:38-39: WARNING: incorrect argument type in IS_ERR_VALUE(uccs -> tx_base_offset)
    drivers/net/ethernet/freescale/fs_enet/mac-fcc.c:110:35-36: WARNING: unknown argument type in IS_ERR_VALUE(fpi -> dpram_offset)

    [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927
    [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581

    Regards
    Andrzej


    Andrzej Hajda (7):
    netfilter: fix IS_ERR_VALUE usage
    MIPS: module: fix incorrect IS_ERR_VALUE macro usages
    drivers: char: mem: fix IS_ERROR_VALUE usage
    atmel-isi: fix IS_ERR_VALUE usage
    serial: clps711x: fix IS_ERR_VALUE usage
    fbdev: exynos: fix IS_ERR_VALUE usage
    usb: gadget: fsl_qe_udc: fix IS_ERR_VALUE usage

    arch/mips/kernel/module-rela.c | 2 +-
    arch/mips/kernel/module.c | 2 +-
    drivers/char/mem.c | 2 +-
    drivers/media/platform/soc_camera/atmel-isi.c | 4 ++--
    drivers/tty/serial/clps711x.c | 14 ++++++++------
    drivers/usb/gadget/udc/fsl_qe_udc.c | 2 +-
    drivers/video/fbdev/exynos/exynos_mipi_dsi.c | 6 +++---
    include/linux/netfilter/x_tables.h | 6 +++---
    net/ipv4/netfilter/arp_tables.c | 11 +++++++----
    net/ipv4/netfilter/ip_tables.c | 12 ++++++++----
    net/ipv6/netfilter/ip6_tables.c | 13 +++++++++----
    11 files changed, 44 insertions(+), 30 deletions(-)

    --
    1.9.1

    \
     
     \ /
      Last update: 2016-02-15 16:01    [W:4.147 / U:1.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site