Messages in this thread | | | Subject | Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer | From | Sudeep Holla <> | Date | Mon, 15 Feb 2016 12:38:30 +0000 |
| |
On 15/02/16 12:31, Jassi Brar wrote: > On Mon, Feb 15, 2016 at 5:47 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: >> Hi Jassi, >> >> On 11/02/16 17:13, Sudeep Holla wrote: >>> >>> Hi Lee, Jassi, >>> >>> Assuming mailbox-test was designed to be generic, I am trying to extend >>> it to support single channel with separate Tx and Rx buffer. With these >>> changes I am able to test arm_mhu driver. However I couldn't understand >>> the intention of converting buffer to ASCII hex dump in read method. >>> I have a local change to remove that so that it can deal with any data >>> in any format(e.g. some protocol format) and userspace can deal with the >>> actual interpretation of the data. Let me know your thoughts on that. >>> >> >> Can you review this ? It would be good to get this in for v4.6 >> > Seems simple enough. So once you and Lee are in sync... >
That was quick :). Anyways IIUC Lee agrees with most of the changes.
The question I am asking is not part of this series, I didn't make the change to remove hexdump yet, I am trying to understand the reasoning for doing that and also explaining my requirement as why I want to remove it.
-- Regards, Sudeep
| |