lkml.org 
[lkml]   [2016]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] auxdisplay: ht16k33: Driver for LED controller.
On Fri, 12 Feb 2016 09:12:43 -0600
Rob Herring <robh@kernel.org> wrote:

> On Tue, Feb 09, 2016 at 12:31:08PM +0100, Robin van der Gracht wrote:
> > This is a driver for the Holtek HT16K33 LED controller with keyscan.
> >
> > Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> > ---
> > Changes in v2:
> > - Fixed build error reported by kbuild test robot by including
> > mm.h
> >
> > .../devicetree/bindings/display/ht16k33.txt | 42 ++
> > drivers/auxdisplay/Kconfig | 9 +
> > drivers/auxdisplay/Makefile | 1 +
> > drivers/auxdisplay/ht16k33.c | 573
> > +++++++++++++++++++++ 4 files changed, 625 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/display/ht16k33.txt create mode
> > 100644 drivers/auxdisplay/ht16k33.c
> >
> > diff --git a/Documentation/devicetree/bindings/display/ht16k33.txt
> > b/Documentation/devicetree/bindings/display/ht16k33.txt new file
> > mode 100644 index 0000000..45fbabb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/ht16k33.txt
> > @@ -0,0 +1,42 @@
> > +Holtek ht16k33 RAM mapping 16*8 LED controller driver with keyscan
> > +-------------------------------------------------------------------------------
> > +
> > +Required properties:
> > +- compatible: "ht,ht16k33"
> > +- reg: I2C slave address of
> > the chip. +- interrupt-parent: A phandle pointing to the
> > interrupt controller
> > + serving the
> > interrupt for this chip. +- interrupts:
> > Interrupt specification for the key pressed interrupt. +-
> > refresh-rate: Display update interval in HZ.
>
> Add units: "-hz"
>
> > +- debounce-delay-ms: Debouncing interval time in
> > microseconds. +- linux,keymap: The keymap
> > for keys as described in the binding
> > + document
> > (devicetree/bindings/input/matrix-keymap.txt).
>
> The alignment of the descriptions here seem to be random. Please line
> them up.
>
> > +
> > +Optional properties:
> > +- linux,no-autorepeat: Disable keyrepeat.
> > +- default-brightness: Initial brightness setting [0-15] (15
> > if not set).
>
> default-brightness-level seem a bit more common.
>

Thanks for reviewing Rob. I'll take your comments into account and
resend an adjusted patch.

Best regards,

--
Robin van der Gracht
Protonic Holland
tel.: +31 (0) 229 212928
fax.: +31 (0) 229 210930
Factorij 36 / 1689 AL Zwaag

\
 
 \ /
  Last update: 2016-02-15 11:01    [W:0.052 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site