lkml.org 
[lkml]   [2016]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/23] perf tools: Change perf_mem__lvl_scnprintf to return nb of displayed bytes
    Date
    Moving strncat/strcpy calls into scnprintf to easily track
    number of displayed bytes. It will be used in following patch.

    Link: http://lkml.kernel.org/n/tip-9q9h9trua9zljnw26c56memh@git.kernel.org
    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    ---
    tools/perf/util/mem-events.c | 13 +++++++------
    tools/perf/util/mem-events.h | 2 +-
    2 files changed, 8 insertions(+), 7 deletions(-)

    diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
    index 440221ca4f8a..5f713d77ac8a 100644
    --- a/tools/perf/util/mem-events.c
    +++ b/tools/perf/util/mem-events.c
    @@ -183,7 +183,7 @@ static const char * const mem_lvl[] = {
    "Uncached",
    };

    -void perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
    +int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
    {
    size_t i, l = 0;
    u64 m = PERF_MEM_LVL_NA;
    @@ -208,15 +208,16 @@ void perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
    strcat(out, " or ");
    l += 4;
    }
    - strncat(out, mem_lvl[i], sz - l);
    - l += strlen(mem_lvl[i]);
    + l += scnprintf(out + l, sz - l, mem_lvl[i]);
    }
    if (*out == '\0')
    - strcpy(out, "N/A");
    + l += scnprintf(out, sz - l, "N/A");
    if (hit)
    - strncat(out, " hit", sz - l);
    + l += scnprintf(out + l, sz - l, " hit");
    if (miss)
    - strncat(out, " miss", sz - l);
    + l += scnprintf(out + l, sz - l, " miss");
    +
    + return l;
    }

    static const char * const snoop_access[] = {
    diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
    index ce9ed0540014..a06efff4ef09 100644
    --- a/tools/perf/util/mem-events.h
    +++ b/tools/perf/util/mem-events.h
    @@ -46,7 +46,7 @@ char *perf_mem_events__name(int i);

    struct mem_info;
    int perf_mem__tlb_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
    -void perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
    +int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
    void perf_mem__snp_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
    void perf_mem__lck_scnprintf(char *out, size_t sz, struct mem_info *mem_info);

    --
    2.4.3
    \
     
     \ /
      Last update: 2016-02-15 10:21    [W:4.059 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site