lkml.org 
[lkml]   [2016]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/8] Staging: rts5208: rtsx_transport.c: Align to open parenthesis
On Thu, Feb 11, 2016 at 10:56:08PM -0800, Shaun Ren wrote:
> This patch fixes the alignment issue reported by checkpatch.pl:
>
> CHECK: Alignment should match open parenthesis
>
> Add a unsigned char *sgbuffer in rtsx_stor_access_xfer_buffer to make the
> following memcpy logic easier to read.
>
> Add a struct scatterlist *sg in the use_sg branch of
> rtsx_transfer_data_partial to make the parameters of the
> rtsx_transfer_sglist_adma_partial call fit in 80 character lines after
> aligning them to the open parenthesis.
>
> Refactor memcpy logic in rtsx_stor_access_xfer_buf to make it more legible.
>
> Signed-off-by: Shaun Ren <shaun.ren@linux.com>
> ---
> drivers/staging/rts5208/rtsx_transport.c | 69 +++++++++++++++++++-------------
> Changes since v3
> * Fixed misalignment of the last parameter of rtsx_stor_access_xfer_buf()
> * Refactored memcpy in rtsx_stor_access_xfer_buf() for legibility

Where are the 7 other patches in this series?

Please resend all of them.

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-02-15 02:21    [W:0.070 / U:1.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site