Messages in this thread | | | Date | Sat, 13 Feb 2016 00:08:38 +0100 | Subject | Re: [PATCH v2 3/9] ACPI: introduce acpi_table_parse2() | From | "Rafael J. Wysocki" <> |
| |
On Fri, Feb 12, 2016 at 7:51 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Fri, Feb 12, 2016 at 08:43:34PM +0300, Aleksey Makarov wrote: >> The function acpi_table_parse() has some problems: >> 1 It can be called only from __init code >> 2 It does not pass any data to the handler >> 3 It just throws out the value returned from the handler >> >> These issues are addressed in this patch > > Why not just fix acpi_table_parse(), like you have, and not add a new > API call with a "2" at the end of it. That seems crazy to try to > maintain that level of apis. > > But I'm not the acpi maintainer(s), so it's their call...
The ACPI maintainer agrees.
Thanks, Rafael
| |