| Date | Fri, 12 Feb 2016 15:05:06 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 09/54] perf tools: Enable passing event to BPF object |
| |
On Fri, Feb 05, 2016 at 02:01:34PM +0000, Wang Nan wrote:
SNIP
> + > + op = bpf_map__add_newop(map); > + if (IS_ERR(op)) > + return PTR_ERR(op); > + op->op_type = BPF_MAP_OP_SET_EVSEL; > + op->v.evsel = evsel; > + return 0; > +} > + > +static int > +bpf_map__config_event(struct bpf_map *map, > + struct parse_events_term *term, > + struct perf_evlist *evlist) > +{ > + if (!term->err_val) { > + pr_debug("Config value not set\n"); > + return -BPF_LOADER_ERRNO__OBJCONF_CONF; > + } > + > + if (!term->type_val == PARSE_EVENTS__TERM_TYPE_STR) {
this failed to compiled due to
CC util/bpf-loader.o util/bpf-loader.c: In function ‘bpf_map__config_event’: util/bpf-loader.c:1013:22: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses] if (!term->type_val == PARSE_EVENTS__TERM_TYPE_STR) { ^ cc1: all warnings being treated as errors
jirka
|